keycard bugfixes #9053

dmitryn · 2019-09-26T13:49:06Z

fixes #8989
fixes #9023
fixes #9028

Summary

Hide keycard option from profile settings for regular users
Temporary hide "Add new account" option in Wallet for keycard users (it doesn't for keycard now Impossible to add new account in wallet if profile is created with keycard #9019)
Fix redirect when Cancel keycard setup pressed Redirect to blank Unlock screen if tap "Cancel" during onboarding flow #9023
Fix setting up 2 keycards on 1 phone Crash at attempt to use second multiaccount with keycard #9028

status: ready

status-github-bot · 2019-09-26T13:49:12Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

status-im-auto · 2019-09-26T13:57:55Z

Jenkins Builds

Click to see older builds (44)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`60ff2a5`	#1	2019-09-26 13:57:55	~8 min	`ios`	📦`ipa` 📲

✔️	`5fca8e0`	#2	2019-09-26 14:09:25	~9 min	`ios`	📦`ipa` 📲
✔️	`5fca8e0`	#2	2019-09-26 14:12:54	~12 min	`android-e2e`	📦`apk` 📲
✔️	`5fca8e0`	#2	2019-09-26 14:13:34	~13 min	`macos`	📦`dmg`
✔️	`5fca8e0`	#2	2019-09-26 14:14:19	~13 min	`windows`	📦`exe`
✔️	`5fca8e0`	#2	2019-09-26 14:19:36	~19 min	`linux`	📦`App`
✔️	`5fca8e0`	#2	2019-09-26 14:26:54	~26 min	`android`	📦`apk` 📲

✔️	`8f59944`	#3	2019-09-26 15:17:09	~10 min	`ios`	📦`ipa` 📲
✔️	`8f59944`	#3	2019-09-26 15:19:32	~13 min	`android-e2e`	📦`apk` 📲
✔️	`8f59944`	#3	2019-09-26 15:19:47	~13 min	`android`	📦`apk` 📲
✔️	`8f59944`	#3	2019-09-26 15:19:48	~13 min	`macos`	📦`dmg`
✔️	`8f59944`	#3	2019-09-26 15:20:06	~13 min	`linux`	📦`App`
✔️	`8f59944`	#3	2019-09-26 15:20:24	~13 min	`windows`	📦`exe`

✔️	`fbb8710`	#4	2019-09-27 12:04:35	~11 min	`ios`	📦`ipa` 📲
✔️	`fbb8710`	#4	2019-09-27 12:05:10	~12 min	`linux`	📦`App`
✔️	`fbb8710`	#4	2019-09-27 12:05:25	~12 min	`macos`	📦`dmg`
✔️	`fbb8710`	#4	2019-09-27 12:05:40	~12 min	`windows`	📦`exe`
✔️	`fbb8710`	#4	2019-09-27 12:06:36	~13 min	`android-e2e`	📦`apk` 📲
✔️	`fbb8710`	#4	2019-09-27 12:06:53	~13 min	`android`	📦`apk` 📲

❌	`75d0b2a`	#5	2019-09-27 12:44:43	~3 min	`android-e2e`	📄`log`
❌	`75d0b2a`	#5	2019-09-27 12:50:29	~9 min	`windows`	📄`log`
✔️	`75d0b2a`	#5	2019-09-27 12:52:13	~11 min	`ios`	📦`ipa` 📲
✔️	`75d0b2a`	#5	2019-09-27 12:53:20	~12 min	`linux`	📦`App`
✔️	`75d0b2a`	#5	2019-09-27 12:53:28	~12 min	`macos`	📦`dmg`
✔️	`75d0b2a`	#5	2019-09-27 12:54:24	~13 min	`android`	📦`apk` 📲
✔️	`75d0b2a`	#6	2019-09-27 14:44:31	~15 min	`android-e2e`	📦`apk` 📲

❌	`514a5c9`	#6	2019-09-27 17:41:37	~48 sec	`linux`	📄`log`
✔️	`514a5c9`	#6	2019-09-27 17:58:06	~17 min	`ios`	📦`ipa` 📲
✔️	`514a5c9`	#7	2019-09-27 17:58:43	~17 min	`android-e2e`	📦`apk` 📲
✔️	`514a5c9`	#6	2019-09-27 17:58:43	~17 min	`macos`	📦`dmg`
✔️	`514a5c9`	#6	2019-09-27 18:06:53	~26 min	`windows`	📦`exe`
✔️	`514a5c9`	#6	2019-09-27 18:13:54	~33 min	`android`	📦`apk` 📲

❌	`ebb75b9`	#7	2019-09-28 13:58:40	~10 min	`windows`	📄`log`
✔️	`ebb75b9`	#7	2019-09-28 13:59:34	~11 min	`ios`	📦`ipa` 📲
✔️	`ebb75b9`	#7	2019-09-28 14:01:34	~13 min	`macos`	📦`dmg`
✔️	`ebb75b9`	#7	2019-09-28 14:02:13	~14 min	`linux`	📦`App`
✔️	`ebb75b9`	#7	2019-09-28 14:02:36	~14 min	`android`	📦`apk` 📲
✔️	`ebb75b9`	#8	2019-09-28 14:02:36	~14 min	`android-e2e`	📦`apk` 📲

❌	`1d760d9`	#8	2019-10-01 16:56:49	~3 min	`macos`	📄`log`
❌	`1d760d9`	#8	2019-10-01 16:59:26	~5 min	`linux`	📄`log`
❌	`1d760d9`	#8	2019-10-01 16:59:34	~5 min	`windows`	📄`log`
✔️	`1d760d9`	#8	2019-10-01 17:02:27	~8 min	`ios`	📦`ipa` 📲
✔️	`1d760d9`	#8	2019-10-01 17:06:55	~13 min	`android`	📦`apk` 📲
✔️	`1d760d9`	#9	2019-10-01 17:07:51	~14 min	`android-e2e`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b98d1e7`	#9	2019-10-08 08:56:12	~9 min	`ios`	📦`ipa` 📲
✔️	`b98d1e7`	#9	2019-10-08 09:00:02	~13 min	`macos`	📦`dmg`
✔️	`b98d1e7`	#9	2019-10-08 09:00:13	~13 min	`linux`	📦`App`
✔️	`b98d1e7`	#9	2019-10-08 09:00:34	~13 min	`android`	📦`apk` 📲
✔️	`b98d1e7`	#10	2019-10-08 09:00:34	~14 min	`android-e2e`	📦`apk` 📲
✔️	`b98d1e7`	#9	2019-10-08 09:01:41	~15 min	`windows`	📦`exe`

❌	`7a642c7`	#10	2019-10-08 11:33:39	~13 min	`android`	📄`log`
✔️	`7a642c7`	#11	2019-10-08 11:33:46	~13 min	`android-e2e`	📦`apk` 📲

src/status_im/ui/screens/profile/user/views.cljs

src/status_im/ui/screens/wallet/accounts/views.cljs

src/status_im/ui/screens/profile/user/views.cljs

yenda · 2019-09-28T11:23:53Z

lgtm squash and rebase before we test it please

statustestbot · 2019-10-08T09:26:49Z

98% of end-end tests have passed

Total executed tests: 47
Failed tests: 1
Passed tests: 46

Failed tests (1)

Click to expand

1. test_send_token_with_7_decimals
Device 1: Wait for MultiaccountMoreOptions Device 1: SignInPhraseText is wrap iris mate `Device 1: 'OkGotItButton' is still visible on the screen after 10 seconds` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (46)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
6. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
7. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
9. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
10. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
11. test_add_to_contacts
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
12. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
13. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_ens_in_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
15. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
16. test_send_message_in_group_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
17. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
18. test_offline_messaging_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
19. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
20. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
21. test_add_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
22. test_manage_assets
Device sessions Device 1: Steps, video, logs
23. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
24. test_send_emoji
Device sessions Device 1: Steps, video, logs
25. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
26. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
27. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
28. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_logcat_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
30. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
31. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
32. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
33. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
34. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
35. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
36. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
37. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
38. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
39. test_offline_status
Device sessions Device 1: Steps, video, logs
40. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
41. test_unread_messages_counter_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
42. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
43. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
44. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
45. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
46. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs

[#9019] hide Add new account in Wallet for keycard users [#9023] fix redirect on keycard setup cancel Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>

dmitryn added the keycard label Sep 26, 2019

dmitryn requested review from vitvly, yenda and flexsurfer September 26, 2019 13:49

dmitryn requested a review from a team as a code owner September 26, 2019 13:49

dmitryn self-assigned this Sep 26, 2019

auto-assign bot removed the request for review from a team September 26, 2019 13:49

dmitryn changed the title ~~[#8989] hide keycard settings for regular accounts~~ keycard bugfixes Sep 26, 2019

yenda reviewed Sep 27, 2019

View reviewed changes

src/status_im/ui/screens/profile/user/views.cljs Outdated Show resolved Hide resolved

yenda reviewed Sep 27, 2019

View reviewed changes

src/status_im/ui/screens/wallet/accounts/views.cljs Outdated Show resolved Hide resolved

yenda reviewed Sep 27, 2019

View reviewed changes

src/status_im/ui/screens/profile/user/views.cljs Outdated Show resolved Hide resolved

dmitryn force-pushed the bug/8989-hide-keycard-settings-for-regular-users branch from 514a5c9 to ebb75b9 Compare September 28, 2019 13:47

weekly-digest bot mentioned this pull request Sep 29, 2019

Weekly Digest (22 September, 2019 - 29 September, 2019) #9066

Closed

dmitryn mentioned this pull request Sep 30, 2019

Crash at attempt to use second multiaccount with keycard #9028

Closed

dmitryn force-pushed the bug/8989-hide-keycard-settings-for-regular-users branch from ebb75b9 to 1d760d9 Compare October 1, 2019 16:53

weekly-digest bot mentioned this pull request Oct 6, 2019

Weekly Digest (29 September, 2019 - 6 October, 2019) #9110

Closed

dmitryn force-pushed the bug/8989-hide-keycard-settings-for-regular-users branch from 1d760d9 to b98d1e7 Compare October 8, 2019 08:46

flexsurfer approved these changes Oct 8, 2019

View reviewed changes

dmitryn added the request-manual-qa label Oct 8, 2019

dmitryn removed the request-manual-qa label Oct 8, 2019

[#8989] hide keycard settings for regular accounts

7a642c7

[#9019] hide Add new account in Wallet for keycard users [#9023] fix redirect on keycard setup cancel Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>

dmitryn force-pushed the bug/8989-hide-keycard-settings-for-regular-users branch from b98d1e7 to 7a642c7 Compare October 8, 2019 11:19

dmitryn merged commit 7a642c7 into develop Oct 8, 2019

delete-merged-branch bot deleted the bug/8989-hide-keycard-settings-for-regular-users branch October 8, 2019 11:19

weekly-digest bot mentioned this pull request Oct 13, 2019

Weekly Digest (6 October, 2019 - 13 October, 2019) #9186

Closed

StatusWrike unassigned dmitryn Nov 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keycard bugfixes #9053

keycard bugfixes #9053

dmitryn commented Sep 26, 2019 •

edited by StatusWrike

Loading

status-github-bot bot commented Sep 26, 2019

status-im-auto commented Sep 26, 2019 •

edited

Loading

yenda commented Sep 28, 2019

statustestbot commented Oct 8, 2019

keycard bugfixes #9053

keycard bugfixes #9053

Conversation

dmitryn commented Sep 26, 2019 • edited by StatusWrike Loading

Summary

status-github-bot bot commented Sep 26, 2019

Pull Request Checklist

status-im-auto commented Sep 26, 2019 • edited Loading

Jenkins Builds

yenda commented Sep 28, 2019

statustestbot commented Oct 8, 2019

98% of end-end tests have passed

Failed tests (1)

Passed tests (46)

dmitryn commented Sep 26, 2019 •

edited by StatusWrike

Loading

status-im-auto commented Sep 26, 2019 •

edited

Loading